You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this implementation, when setting use_default_exceptions to false the user needs to manually copy the hard-coded exception list and put them as custom_exceptions. And although it is suboptimal, it is not that uncommon. Home Assistant default configuration works in the same way.
I think that creating a system of inclusions/exclusions would only complicate things with little gain since I suspect that use_default_exceptions would only be used in rare circumstances.
I think that this should be implemented only when the swipe exception format is considered stable, to avoid breaking-changes down the road.
If you are interested, upvote the first post with a 👍.
CSS selectors are now implemented in v1.5.0, but before enabling user-defined exceptions I would like to gather more opinions and I would like to wait until the exception format is stable, to avoid breaking-changes in the future.
In the meantime, feel free to propose pull requests with other exceptions, so everyone can benefit from them.
Enhancements
Provide a way to bypass the default hard-coded exceptions
This could be easily done with a flag
use_default_exceptions
which defaults totrue
.This flag would be quite useless alone, therefore the user should be able to add custom exceptions.
Provide a way for the user to add exceptions via CSS selectors
Drawbacks
In this implementation, when setting
use_default_exceptions
tofalse
the user needs to manually copy the hard-coded exception list and put them as custom_exceptions. And although it is suboptimal, it is not that uncommon. Home Assistant default configuration works in the same way.I think that creating a system of inclusions/exclusions would only complicate things with little gain since I suspect that
use_default_exceptions
would only be used in rare circumstances.See also:
The text was updated successfully, but these errors were encountered: