Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer password field is too short to store "bcrypted" passwords #2

Open
Tarabyte opened this issue Apr 19, 2019 · 5 comments
Open

Comments

@Tarabyte
Copy link

Current DB Schema uses VARCHAR(50) column to store customer passwords. Which is too short to store passwords hashed via bcrypt. BCrypt is de-facto standard way when it comes to storing passwords.

Please consider changing Customer#password to be VARCHAR(60) to allow using bcrypt.

@zestian56
Copy link

Im having the same issue

@erkib
Copy link

erkib commented May 7, 2019

+1
I recommend even more space (i.e 150 ch)

@FullyStackedCoder
Copy link

I too have the same issue and dropped using bcrypt for now. Just commented out the bcrypt code.

@Rbwebsol
Copy link

Do NOT limit the maximum length of a password. Use VARCHAR(255) to avoid error.

@babacarcissedia
Copy link

please do as @Rbwebsol recommend. hashes tend to be longer so reserve sufficient amount of length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants