Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes build warnings #971

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes build warnings #971

wants to merge 2 commits into from
+2 −5

Conversation

bocytko
Copy link
Member

@bocytko bocytko commented Feb 15, 2025 •
edited
Loading

Description

Closes #969

Motivation and Context

  • spring-security-config was declared as dependency twice leading to build warnings.
  • maven-javadoc-plugin did not have a version defined leading to build warnings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@bocytko bocytko requested a review from a team as a code owner February 15, 2025 21:06
@bocytko bocytko changed the title Removes duplicated package from pom.xml Fixes build warnings Feb 15, 2025
@bocytko
Copy link
Member Author

bocytko commented Feb 15, 2025

https://github.com/zalando/problem-spring-web/actions/runs/13348678941/job/37282379266?pr=971

Run ./mvnw verify -B
[INFO] Scanning for projects...

image

@bocytko
Copy link
Member Author

bocytko commented Feb 15, 2025

👍

@danielrohe danielrohe added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build warnings in test step
2 participants
@bocytko @danielrohe