Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Refactor ComplementaryDocumentType in two separate models #526

Open
olivierdalang opened this issue Jun 22, 2022 · 2 comments
Open

Refactor ComplementaryDocumentType in two separate models #526

olivierdalang opened this issue Jun 22, 2022 · 2 comments

Comments

@olivierdalang
Copy link
Collaborator

Currently, the ComplementaryDocumentType model mixes both DocumentType categories, and DocumentTypes themselves. This is not very clean as it mixes two different logic in the same model. It also forces document types to be specific to a WOT (so we can't use general types such as "plan", "photo", etc.).

Instead, we should create a distinct DocumentTypeCategory model for the parent, and have the relation to the WOT directly on the child.

(hope it's clear)

@olivierdalang olivierdalang changed the title Refactor ComplementaryDocumentType in two separate odels Refactor ComplementaryDocumentType in two separate models Jun 22, 2022
@rbovard
Copy link
Collaborator

rbovard commented Dec 14, 2022

@AlexandreJunod is it fixed via #642?

@AlexandreJunod
Copy link
Collaborator

@rbovard The user interface has been improved by creating separate views, but the model has not been modified

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants