From fa2720d5892808d291448d771b40445226c5826e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Bovard?= Date: Thu, 25 Apr 2024 10:18:06 +0200 Subject: [PATCH] Generate transaction PDF only if transaction is authorized (#988) --- geocity/apps/submissions/views.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/geocity/apps/submissions/views.py b/geocity/apps/submissions/views.py index 233b56dd9..548c13abb 100644 --- a/geocity/apps/submissions/views.py +++ b/geocity/apps/submissions/views.py @@ -2621,8 +2621,6 @@ def get(self, request, pk, *args, **kwargs): transaction = get_transaction_from_id(pk) submission = transaction.submission_price.submission - submission.generate_and_save_pdf("confirmation", transaction) - if ( not request.user == submission.author or not transaction.status == transaction.STATUS_UNPAID @@ -2631,6 +2629,7 @@ def get(self, request, pk, *args, **kwargs): processor = get_payment_processor(submission.get_form_for_payment()) if processor.is_transaction_authorized(transaction): + submission.generate_and_save_pdf("confirmation", transaction) transaction.set_paid() submission_submit_confirmed(request, submission.pk) @@ -2766,8 +2765,6 @@ def get(self, request, pk, prolongation_date, *args, **kwargs): transaction = get_transaction_from_id(pk) submission = transaction.submission_price.submission - submission.generate_and_save_pdf("confirmation", transaction) - if ( not request.user == submission.author or not transaction.status == transaction.STATUS_UNPAID @@ -2776,9 +2773,11 @@ def get(self, request, pk, prolongation_date, *args, **kwargs): processor = get_payment_processor(submission.get_form_for_payment()) if processor.is_transaction_authorized(transaction): + submission.generate_and_save_pdf("confirmation", transaction) transaction.set_paid() submission.prolongation_date = datetime.fromtimestamp(prolongation_date) _set_prolongation_requested_and_notify(submission, request) + return render( request, "submissions/submission_payment_callback_confirm.html",