From a9b06a49304d85b2e445332f5303242704a56bfc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bendeg=C3=BAz=20Hajnal?= Date: Mon, 13 Jan 2025 16:35:58 +0100 Subject: [PATCH 1/2] fix(pages-components): unique key for address line separators --- packages/pages-components/src/components/address/address.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/pages-components/src/components/address/address.tsx b/packages/pages-components/src/components/address/address.tsx index 19708f4e..cf5b7826 100644 --- a/packages/pages-components/src/components/address/address.tsx +++ b/packages/pages-components/src/components/address/address.tsx @@ -50,10 +50,13 @@ const AddressLine = ({ separator, }: AddressLineProps): JSX.Element => { const addressDOM: JSX.Element[] = []; + let separatorCount = 0; for (const field of line) { if (field === ",") { - addressDOM.push({separator}); + addressDOM.push( + {separator} + ); continue; } From 46fb5b6214ae742a96d27a084c92cc42e0d3c794 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bendeg=C3=BAz=20Hajnal?= Date: Mon, 13 Jan 2025 18:00:10 +0100 Subject: [PATCH 2/2] test(pages-components): add test for address not writing errors to console when multiple separators are used on a line --- .../src/components/address/address.test.tsx | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/packages/pages-components/src/components/address/address.test.tsx b/packages/pages-components/src/components/address/address.test.tsx index 5e49876c..507ce606 100644 --- a/packages/pages-components/src/components/address/address.test.tsx +++ b/packages/pages-components/src/components/address/address.test.tsx @@ -45,4 +45,23 @@ describe("Address", () => { expect(cityEl && regionEl).toBeFalsy(); }); + + it("renders custom lines with separators without warnings", () => { + const originalError = console.error; + console.error = vi.fn(); + + render( +
+ ); + + expect(console.error).not.toHaveBeenCalled(); + + console.error = originalError; + }); });