From f5b0ef0cdc92b7f3631a1be1f05a7abda5b61e0c Mon Sep 17 00:00:00 2001
From: Milton Reder <milt@yetanalytics.com>
Date: Fri, 25 Oct 2024 11:46:12 -0400
Subject: [PATCH] amend mod_assign assessable_submitted (#42)

---
 .../events/mod_assign/assignment_submitted.php  | 17 +++++++++++++++--
 .../existing_assignment_submitted/data.json     |  6 ++++++
 .../statements.json                             | 16 +++++++++++++---
 3 files changed, 34 insertions(+), 5 deletions(-)

diff --git a/src/transformer/events/mod_assign/assignment_submitted.php b/src/transformer/events/mod_assign/assignment_submitted.php
index 457f11561..37dfbd400 100644
--- a/src/transformer/events/mod_assign/assignment_submitted.php
+++ b/src/transformer/events/mod_assign/assignment_submitted.php
@@ -52,14 +52,27 @@ function assignment_submitted(array $config, \stdClass $event) {
     return [[
         'actor' => utils\get_user($config, $user),
         'verb' => $verb,
-        'object' => utils\get_activity\course_assignment($config, $event->contextinstanceid, $assignment->name, $lang),
+        'object' => [
+            'id' => $config['app_url']
+                . '/mod/assign/view.php?id='
+                . $event->contextinstanceid
+                . '#submission',
+            'objectType' => 'Activity',
+            'definition' => [
+                'type' => 'https://xapi.edlm/profiles/edlm-lms/concepts/activity-types/submission',
+                'name' => [
+                    $lang => $assignment->name . ' Submission',
+                ]
+            ]
+        ],
         'context' => [
             'language' => $lang,
             'extensions' => utils\extensions\base($config, $event, $course),
             'contextActivities' => [
                 'parent' => utils\context_activities\get_parent(
                     $config,
-                    $event->contextinstanceid
+                    $event->contextinstanceid,
+                    true
                 ),
                 'category' => [
                     utils\get_activity\site($config),
diff --git a/tests/mod_assign/assignment_submitted/existing_assignment_submitted/data.json b/tests/mod_assign/assignment_submitted/existing_assignment_submitted/data.json
index ad710a0a7..cd911388d 100644
--- a/tests/mod_assign/assignment_submitted/existing_assignment_submitted/data.json
+++ b/tests/mod_assign/assignment_submitted/existing_assignment_submitted/data.json
@@ -10,5 +10,11 @@
       "id": 1,
       "name": "test_name"
     }
+  ],
+  "modules": [
+    {
+      "id": 1,
+      "name": "assign"
+    }
   ]
 }
diff --git a/tests/mod_assign/assignment_submitted/existing_assignment_submitted/statements.json b/tests/mod_assign/assignment_submitted/existing_assignment_submitted/statements.json
index 2def27b21..fbd855c2e 100644
--- a/tests/mod_assign/assignment_submitted/existing_assignment_submitted/statements.json
+++ b/tests/mod_assign/assignment_submitted/existing_assignment_submitted/statements.json
@@ -14,11 +14,12 @@
       }
     },
     "object": {
-      "id": "http://www.example.org/mod/assign/view.php?id=1",
+      "id": "http://www.example.org/mod/assign/view.php?id=1#submission",
+      "objectType": "Activity",
       "definition": {
-        "type": "http://adlnet.gov/expapi/activities/assessment",
+        "type": "https://xapi.edlm/profiles/edlm-lms/concepts/activity-types/submission",
         "name": {
-          "en": "test_name"
+          "en": "test_name Submission"
         }
       }
     },
@@ -34,6 +35,15 @@
       },
       "contextActivities": {
         "parent": [
+          {
+            "id": "http://www.example.org/mod/assign/view.php?id=1",
+            "definition": {
+              "type": "https://xapi.edlm/profiles/edlm-lms/concepts/activity-types/assignment",
+              "name": {
+                "en": "test_name"
+              }
+            }
+          },
           {
             "id": "http://www.example.org/course/section.php?id=1",
             "objectType": "Activity",