From 5a0e344160c08cd1adce15d2b586299b7bcecc3b Mon Sep 17 00:00:00 2001
From: Milton Reder <milt@yetanalytics.com>
Date: Wed, 9 Oct 2024 15:06:10 -0400
Subject: [PATCH] remove hard type from resource

---
 .../mod_resource/course_module_viewed.php     |   3 +-
 .../existing_module/statements.json           | 126 +++++++++---------
 2 files changed, 64 insertions(+), 65 deletions(-)

diff --git a/src/transformer/events/mod_resource/course_module_viewed.php b/src/transformer/events/mod_resource/course_module_viewed.php
index 630c85a55..fc25d766d 100644
--- a/src/transformer/events/mod_resource/course_module_viewed.php
+++ b/src/transformer/events/mod_resource/course_module_viewed.php
@@ -52,8 +52,7 @@ function course_module_viewed(array $config, \stdClass $event) {
         'object' => utils\get_activity\course_module(
             $config,
             $course,
-            $event->contextinstanceid,
-            'http://id.tincanapi.com/activitytype/resource'
+            $event->contextinstanceid
         ),
         'context' => [
             'language' => $lang,
diff --git a/tests/mod_resource/course_module_viewed/existing_module/statements.json b/tests/mod_resource/course_module_viewed/existing_module/statements.json
index 056cd66d1..6a8d41609 100644
--- a/tests/mod_resource/course_module_viewed/existing_module/statements.json
+++ b/tests/mod_resource/course_module_viewed/existing_module/statements.json
@@ -1,70 +1,70 @@
 [
-    {
-        "actor": {
-            "name": "test_fullname",
-            "account": {
-                "homePage": "http://www.example.org",
-                "name": "1"
-            }
-        },
-        "verb": {
-            "id": "http://id.tincanapi.com/verb/viewed",
-            "display": {
-                "en": "viewed"
+  {
+    "actor": {
+      "name": "test_fullname",
+      "account": {
+        "homePage": "http://www.example.org",
+        "name": "1"
+      }
+    },
+    "verb": {
+      "id": "http://id.tincanapi.com/verb/viewed",
+      "display": {
+        "en": "viewed"
+      }
+    },
+    "object": {
+      "id": "http://www.example.org/mod/resource/view.php?id=1",
+      "definition": {
+        "type": "http://id.tincanapi.com/activitytype/resource",
+        "name": {
+          "en": "test_name"
+        }
+      }
+    },
+    "context": {
+      "language": "en",
+      "extensions": {
+        "http://lrs.learninglocker.net/define/extensions/info": {
+          "http://moodle.org": "1.0.0",
+          "https://github.com/xAPI-vle/moodle-logstore_xapi": "0.0.0-development",
+          "event_name": "\\mod_resource\\event\\course_module_viewed",
+          "event_function": "\\src\\transformer\\events\\mod_resource\\course_module_viewed"
+        }
+      },
+      "contextActivities": {
+        "grouping": [
+          {
+            "id": "http://www.example.org",
+            "definition": {
+              "type": "http://id.tincanapi.com/activitytype/lms",
+              "name": {
+                "en": "test_name"
+              }
             }
-        },
-        "object": {
-            "id": "http://www.example.org/mod/resource/view.php?id=1",
+          },
+          {
+            "id": "http://www.example.org/course/view.php?id=1",
             "definition": {
-                "type": "http://id.tincanapi.com/activitytype/resource",
-                "name": {
-                    "en": "test_name"
-                }
+              "type": "https://w3id.org/xapi/cmi5/activitytype/course",
+              "name": {
+                "en": "test_name"
+              }
             }
-        },
-        "context": {
-            "language": "en",
-            "extensions": {
-                "http://lrs.learninglocker.net/define/extensions/info": {
-                    "http://moodle.org": "1.0.0",
-                    "https://github.com/xAPI-vle/moodle-logstore_xapi": "0.0.0-development",
-                    "event_name": "\\mod_resource\\event\\course_module_viewed",
-                    "event_function": "\\src\\transformer\\events\\mod_resource\\course_module_viewed"
-                }
-            },
-            "contextActivities": {
-                "grouping": [
-                    {
-                        "id": "http://www.example.org",
-                        "definition": {
-                            "type": "http://id.tincanapi.com/activitytype/lms",
-                            "name": {
-                                "en": "test_name"
-                            }
-                        }
-                    },
-                    {
-                        "id": "http://www.example.org/course/view.php?id=1",
-                        "definition": {
-                            "type": "https://w3id.org/xapi/cmi5/activitytype/course",
-                            "name": {
-                                "en": "test_name"
-                            }
-                        }
-                    }
-                ],
-                "category": [
-                    {
-                        "id": "http://moodle.org",
-                        "definition": {
-                            "type": "http://id.tincanapi.com/activitytype/source",
-                            "name": {
-                                "en": "Moodle"
-                            }
-                        }
-                    }
-                ]
+          }
+        ],
+        "category": [
+          {
+            "id": "http://moodle.org",
+            "definition": {
+              "type": "http://id.tincanapi.com/activitytype/source",
+              "name": {
+                "en": "Moodle"
+              }
             }
-        }
+          }
+        ]
+      }
     }
+  }
 ]