Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeOfDay no longer roundtrips through sqlite #1500

Open
NorfairKing opened this issue Jun 3, 2023 · 4 comments
Open

TimeOfDay no longer roundtrips through sqlite #1500

NorfairKing opened this issue Jun 3, 2023 · 4 comments

Comments

@NorfairKing
Copy link
Contributor

NorfairKing commented Jun 3, 2023 •
edited
Loading

Tried with latest master (434f49266749cad6f074920fb61ad3ec6ef90bea) as well as the version in lts-20.23:

When inserting 00:56:03.917384676344, I get out 00:56:03.

This is a regression and I'm surprised that this wasn't caught by tests.

This means I cannot upgrade from LTS 19 (nixos-22.11) to LTS 20 (nixos-23.05).
@NorfairKing
Copy link
Contributor Author

NorfairKing commented Jun 3, 2023 •
edited
Loading

Some digging into this reveals that only the persistent-sqlite version has changed.

Previous version: 
persistent-2.13.3.5
persistent-sqlite: 2.13.1.0

New version:
persistent-2.13.3.5
persistent-sqlite: 2.13.1.1

And it looks like this is the only commit that differs: 6fdbf84

@NorfairKing
Copy link
Contributor Author

However, downgrading to 2.13.1.0 manually like this does not fix the issue:

- persistent-2.13.3.5
- persistent-sqlite-2.13.1.0

@NorfairKing NorfairKing mentioned this issue Jun 3, 2023
Closed
@Vlix
Copy link
Contributor

Vlix commented Jun 4, 2023

The test is explicitly truncated, it seems. 🤔

@NorfairKing
Copy link
Contributor Author

Potentially vaguely related: haskell/time#232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NorfairKing @Vlix