From d91af717722dc93b3e4e9f1e24e37e6c665c2396 Mon Sep 17 00:00:00 2001 From: Liang Huang Date: Thu, 6 Jun 2024 16:52:53 +0800 Subject: [PATCH 1/2] . Signed-off-by: Liang Huang --- .github/workflows/main.yaml | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 954e3054ee7d0..d28b30d0981f2 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -267,21 +267,14 @@ jobs: ls -lah - name: Upload coverage to Codecov if: ${{ github.repository == 'milvus-io/milvus' }} - uses: codecov/codecov-action@v4 - id: upload_cov + uses: Wandalen/wretry.action with: - token: ${{ secrets.CODECOV_TOKEN }} - files: ./go_coverage.txt,./lcov_output.info,./it_coverage.txt - name: ubuntu-20.04-unittests - fail_ci_if_error: true - disable_safe_directory: true - - name: Retry Upload coverage to Codecov - if: ${{ failure() && github.repository == 'milvus-io/milvus' }} - uses: codecov/codecov-action@v4 - id: retry_upload_cov - with: - token: ${{ secrets.CODECOV_TOKEN }} - files: ./go_coverage.txt,./lcov_output.info,./it_coverage.txt - name: ubuntu-20.04-unittests - fail_ci_if_error: true - disable_safe_directory: true + action: codecov/codecov-action@v4 + with: | + token: ${{ secrets.CODECOV_TOKEN }} + files: ./go_coverage.txt,./lcov_output.info,./it_coverage.txt + name: ubuntu-20.04-unittests + fail_ci_if_error: true + disable_safe_directory: true + attempt_limit: 10 + attempt_delay: 30000 From b603a22af8a8800cae969b031500d588e3daa8f7 Mon Sep 17 00:00:00 2001 From: Liang Huang Date: Thu, 6 Jun 2024 16:58:12 +0800 Subject: [PATCH 2/2] . Signed-off-by: Liang Huang --- .github/workflows/main.yaml | 3 ++- tests/scripts/uninstall_milvus.sh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index d28b30d0981f2..44daa8848eeca 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -266,7 +266,7 @@ jobs: run: | ls -lah - name: Upload coverage to Codecov - if: ${{ github.repository == 'milvus-io/milvus' }} + # if: ${{ github.repository == 'milvus-io/milvus' }} uses: Wandalen/wretry.action with: action: codecov/codecov-action@v4 @@ -278,3 +278,4 @@ jobs: disable_safe_directory: true attempt_limit: 10 attempt_delay: 30000 + diff --git a/tests/scripts/uninstall_milvus.sh b/tests/scripts/uninstall_milvus.sh index d9ec1b03c3f75..16f8f2bf548ce 100755 --- a/tests/scripts/uninstall_milvus.sh +++ b/tests/scripts/uninstall_milvus.sh @@ -11,6 +11,7 @@ # is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express # or implied. See the License for the specific language governing permissions and limitations under the License. + # Exit immediately for non zero status set -e # Print commands @@ -83,4 +84,4 @@ MILVUS_LABELS2="release=${MILVUS_HELM_RELEASE_NAME}" # Clean up pvc kubectl delete pvc --wait -n "${MILVUS_HELM_NAMESPACE}" $(kubectl get pvc -n "${MILVUS_HELM_NAMESPACE}" -l "${MILVUS_LABELS1}" -o jsonpath='{range.items[*]}{.metadata.name} ') || true -kubectl delete pvc --wait -n "${MILVUS_HELM_NAMESPACE}" $(kubectl get pvc -n "${MILVUS_HELM_NAMESPACE}" -l "${MILVUS_LABELS2}" -o jsonpath='{range.items[*]}{.metadata.name} ') || true \ No newline at end of file +kubectl delete pvc --wait -n "${MILVUS_HELM_NAMESPACE}" $(kubectl get pvc -n "${MILVUS_HELM_NAMESPACE}" -l "${MILVUS_LABELS2}" -o jsonpath='{range.items[*]}{.metadata.name} ') || true