Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PaginatedTable] remove scroll to top on filters change #1547

Open
artemmufazalov opened this issue Oct 28, 2024 · 2 comments
Open

[PaginatedTable] remove scroll to top on filters change #1547

artemmufazalov opened this issue Oct 28, 2024 · 2 comments
Labels
prio/low size/m 🐞 type/bug Something isn't working

Comments

@artemmufazalov
Copy link
Member

parentRef.current.scrollTo(0,0) doesn't work well with table groups - scroll is always set to the container when group is expanded. It there are some expanded groups already, the user will need to scroll all the way down to the expanded group they viewed .

It seems, it's better to remove such scroll at all.

There is an issue, that should be fixed, when with no scroll to top there is no content in table:

  1. I scroll table to some chunk (it's better reproduced with bottom chunks)
  2. I change filters
  3. Found entities count is changed, chunks count is changed
  4. My chunk on the screen is changed - for example I was on 20 chunk, but after filters are changed, there are only 10 chunks left, so my new chunk is 10
  5. No data is displayed in 10 chunk, the chunk isn't active until I somehow change my scroll position
@antonkovalenko
Copy link
Member

hope that #1427 will make it better

@artemmufazalov
Copy link
Member Author

Probably, we should not remove scroll at all, since it won't work good with table groups, without unchanged scroll position we can be at another group when filters change.

For example, we have expanded groups A, B, C, we are looking at group B. We apply some filters, number of entities changes, but scroll position is remained the same, so we are now at group C.

Better solutions is to scroll to current table container, for table group it will be table group itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio/low size/m 🐞 type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants