Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New planner format? #34

Open
oskarsVismanis opened this issue Jan 14, 2025 · 1 comment
Open

New planner format? #34

oskarsVismanis opened this issue Jan 14, 2025 · 1 comment

Comments

@oskarsVismanis
Copy link

According to this PR, the format of how the controllers are loaded has changed in MoveIt2 and, I assume, to make this package compatible with Jazzy, @ycheng517, you've updated the format as well? I noticed this when running demo.launch.py and getting the error expected [string_array] got [string].

And besides this, using the request_adapters specified in the current ompl_planning.yaml

  - default_planning_request_adapters/CheckStartStateBounds
  - default_planning_request_adapters/CheckStartStateCollision
  - default_planning_request_adapters/ResolveConstraintFrames
  - default_planning_request_adapters/ValidateWorkspaceBounds

I get the error that these do not exist, but the demo works fine with these ones specified

default_planner_request_adapters/AddTimeOptimalParameterization
default_planner_request_adapters/FixWorkspaceBounds
default_planner_request_adapters/FixStartStateBounds
default_planner_request_adapters/FixStartStateCollision
default_planner_request_adapters/FixStartStatePathConstraints

I assume this is all from the move to moveit2 jazzy branch. As I'm still on humble, I fixed all this, so it would work for me, but perhaps a humble branch should be created? Or is that function currently done by the iron branch? As there is now the annin_ prefix to packages, I was thinking a new branch would make more sense?

I am also working on adding a prefix or tf_prefix to the .urdf-s, which I could then contribute to the package (probably to the iron/humble branch initially, as that is the one I'm working with)

@ycheng517
Copy link
Owner

Hi @oskarsVismanis I will make a humble branch in a short while. It'll take some effort to get Gazebo working again, as it was a big change to upgrade to Jazzy. Anyways stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants