Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in config settings #55

Open
Dhak0s opened this issue Nov 20, 2024 · 5 comments
Open

Error in config settings #55

Dhak0s opened this issue Nov 20, 2024 · 5 comments

Comments

@Dhak0s
Copy link

Dhak0s commented Nov 20, 2024

It seems that in the sample config file, Title: is incorrect, it should instead be title: for changes to take effect.
It also seems that changing hide_other_shares: from false to true has no effect as all registered users can still see Other Shares.

@ybizeul
Copy link
Owner

ybizeul commented Nov 20, 2024

You are right, Title: should be title: I'll fix the documentation.

I couldn't reproduce the other issue though, did you restart hupload and reload the web page ?

@Dhak0s
Copy link
Author

Dhak0s commented Nov 20, 2024

I have tried:

  • logging out and changing users
  • restarting the container
  • recreating the container
  • creating new shares and changing users to see if it only affects newly created shares
  • variations of 'true', 'True' & 'TRUE' for hide_other_shares

This is my config.yml:

  • note: All other config options are working.
title: File Share
default_validity_days: 3
default_exposure: upload
hide_other_shares: true
auth:
  type: file
  options:
    path: users.yml
storage:
  type: file
  options:
    path: data
    max_file_mb: 51200
    max_share_mb: 102400
messages:
  - title: Test message
    message: |
      This is a test.

@Dhak0s
Copy link
Author

Dhak0s commented Nov 20, 2024

I have noticed this and beleive it's the issue -

Multi user (all admins see all shares, but see their own listed separately first)

I have added a custom user but how do I make them non-admin? All users can see Other Shares

My users.yml looks like the following:

- username: user1
  password: $2y$10$LIcTF3HKNhV6qh3oi3ysHOnhiXpLOU22N61JzZXoSWQbNOpDhS/g.
- username: user2
  password: $2y$10$Rwj3rjfmXuflxds.uhgKReiXFy5VRziYuDDw/aO1w9ut9BzafTFr6
- username: admin
  password: $2y$10$LIcTF3HKNhV6qh3oi3ysHOnhiXpLOU22N61JzZXoSWQbNOpDhS/g.
- username: testuser
  password: $2y$10$LIcTF3HKNhV6qh3oi3ysHOnhiXpLOU22N61JzZXoSWQbNOpDhS/g.

@ybizeul
Copy link
Owner

ybizeul commented Nov 28, 2024

Defined users are all admins, your first thought is correct I believe : hide_other_shares: true should make so that all defined users (admins) only see their own shares, instead of seeing other people shares under "Others".

Something is wrong probably, I'll try and provide a debug build so you can run some diags

@Dhak0s
Copy link
Author

Dhak0s commented Nov 29, 2024

No worries, I'd be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants