Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache File, and missing files #65

Open
bschollnick opened this issue May 9, 2022 · 0 comments
Open

Cache File, and missing files #65

bschollnick opened this issue May 9, 2022 · 0 comments

Comments

@bschollnick
Copy link

Folks,

  1. Ran into a situation where files where not downloading, so I used @matega fork. https://github.com/matega/humblebundle-downloader
  2. But the same files weren't downloading. After investigating, it appears that they were added to the cache even though they didn't download correctly? But there weren't any error messages with the failures?

This leads to the following questions/suggestions:

  • Why hide the cache file? I agree .cache hides it, and that's not necessarily bad. But when I didn't see the cache file in the directory, I told myself that I was misremembering about the cache... Until I started digging in the code to see if I could figure out why this was happening. It's a single file, and telling someone to delete it is a simple fix, when they can see the file.
  • There is no way to tell the app to not overwrite files, so for example, I deleted the cache file, and now it's downloading the missing files. I've added a simple os.path.exists call to check if the file exists, and added --no_overwrite to the cli code. So if that flag is active, it won't overwrite an existing file. But I need to check to see if MD5 hashes are available for the non-trove code, etc.
  • --update should also verify that the file exists, and if not, attempt the download.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant