Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostalAddressRow: Native Country Selector #258

Closed
marbetschar opened this issue Feb 11, 2016 · 5 comments
Closed

PostalAddressRow: Native Country Selector #258

marbetschar opened this issue Feb 11, 2016 · 5 comments

Comments

@marbetschar
Copy link
Contributor

Maybe the PostalAddress Row should support the selection of a country instead of typing it in as String. I'm thinking of a SelectorController displaying a list of translated country names.

And if a country was selected, it will return the ISO countryCode for it.

Thoughts?

@mats-claassen
Copy link
Member

I am not sure this is in our scope. It seems to me that it is more like a custom row, as you will probably want to have a custom design for the address row as well.

@marbetschar
Copy link
Contributor Author

Oh, ok I can see your concern.

Do you have any idea how we could provide the possibility to use the built in PostalAddressRow but replace the country input field with a selector?

So folks do not have to add a fully customized PostalAddressRow just for country selection?

@marbetschar
Copy link
Contributor Author

marbetschar commented May 18, 2016

@mats-claassen as I'll look into #423 these days, any chance a further enhancement by providing a country selector equally to the native iOS one would make it into the official release?

In my opinion this would make the PostalAddressRow even more useful - but maybe this behaviour should be configurable?

hlfxe

@rufferto
Copy link

The correct way to do this would be a redesigned PostalAddressRow which used xib files for it's cell layout. The country would be separate PickerRow which would swap in the appropriate layout based on the selection. To support addresses internationally the xib file would be localized. This would eliminate the need for placeholder strings and much of the auto layout layout being managed in code right now. It seems from browsing the code the missing piece is a protocol to map the field order back to the NavigationAccessoryView.

@mats-claassen
Copy link
Member

PostalAddressRow has been moved to EurekaCommunity and there is an issue regarding this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants