From 1243c7b2ede9eab946d2cd632beab9c78a9edb48 Mon Sep 17 00:00:00 2001
From: Josh Holmer <jholmer.in@gmail.com>
Date: Wed, 22 Mar 2023 08:50:41 -0400
Subject: [PATCH] Remove useless `allow` lints and organize/comment properly

---
 src/bin/rav1e-ch.rs | 15 +++++----------
 src/bin/rav1e.rs    | 16 ++++++----------
 src/lib.rs          | 21 ++++++++-------------
 3 files changed, 19 insertions(+), 33 deletions(-)

diff --git a/src/bin/rav1e-ch.rs b/src/bin/rav1e-ch.rs
index 212d0afb90..034460fee1 100644
--- a/src/bin/rav1e-ch.rs
+++ b/src/bin/rav1e-ch.rs
@@ -8,14 +8,6 @@
 // PATENTS file, you can obtain it at www.aomedia.org/license/patent.
 
 #![deny(bare_trait_objects)]
-#![allow(clippy::cast_lossless)]
-#![allow(clippy::cast_ptr_alignment)]
-#![allow(clippy::cognitive_complexity)]
-#![allow(clippy::needless_range_loop)]
-#![allow(clippy::too_many_arguments)]
-#![allow(clippy::verbose_bit_mask)]
-#![allow(clippy::unreadable_literal)]
-#![allow(clippy::many_single_char_names)]
 // Performance lints
 #![warn(clippy::linkedlist)]
 #![warn(clippy::missing_const_for_fn)]
@@ -26,17 +18,20 @@
 #![warn(clippy::mem_forget)]
 #![warn(clippy::path_buf_push_overwrite)]
 // Clarity/formatting lints
+#![allow(clippy::comparison_chain)]
+#![allow(clippy::enum_variant_names)]
 #![warn(clippy::map_flatten)]
 #![warn(clippy::mut_mut)]
 #![warn(clippy::needless_borrow)]
 #![warn(clippy::needless_continue)]
+#![allow(clippy::needless_range_loop)]
+#![allow(clippy::too_many_arguments)]
 #![warn(clippy::range_plus_one)]
+#![allow(clippy::upper_case_acronyms)]
 // Documentation lints
 #![warn(clippy::doc_markdown)]
 #![warn(clippy::missing_errors_doc)]
 #![warn(clippy::missing_panics_doc)]
-// FIXME: Temporarily disabled due to https://github.com/rust-lang/rust-clippy/issues/9142
-#![allow(clippy::undocumented_unsafe_blocks)]
 
 #[macro_use]
 extern crate log;
diff --git a/src/bin/rav1e.rs b/src/bin/rav1e.rs
index 1eb1928dba..6dfe354ec2 100644
--- a/src/bin/rav1e.rs
+++ b/src/bin/rav1e.rs
@@ -7,15 +7,8 @@
 // Media Patent License 1.0 was not distributed with this source code in the
 // PATENTS file, you can obtain it at www.aomedia.org/license/patent.
 
+// Safety lints
 #![deny(bare_trait_objects)]
-#![allow(clippy::cast_lossless)]
-#![allow(clippy::cast_ptr_alignment)]
-#![allow(clippy::cognitive_complexity)]
-#![allow(clippy::needless_range_loop)]
-#![allow(clippy::too_many_arguments)]
-#![allow(clippy::verbose_bit_mask)]
-#![allow(clippy::unreadable_literal)]
-#![allow(clippy::many_single_char_names)]
 // Performance lints
 #![warn(clippy::linkedlist)]
 #![warn(clippy::missing_const_for_fn)]
@@ -26,17 +19,20 @@
 #![warn(clippy::mem_forget)]
 #![warn(clippy::path_buf_push_overwrite)]
 // Clarity/formatting lints
+#![allow(clippy::comparison_chain)]
+#![allow(clippy::enum_variant_names)]
 #![warn(clippy::map_flatten)]
 #![warn(clippy::mut_mut)]
 #![warn(clippy::needless_borrow)]
 #![warn(clippy::needless_continue)]
+#![allow(clippy::needless_range_loop)]
+#![allow(clippy::too_many_arguments)]
 #![warn(clippy::range_plus_one)]
+#![allow(clippy::upper_case_acronyms)]
 // Documentation lints
 #![warn(clippy::doc_markdown)]
 #![warn(clippy::missing_errors_doc)]
 #![warn(clippy::missing_panics_doc)]
-// FIXME: Temporarily disabled due to https://github.com/rust-lang/rust-clippy/issues/9142
-#![allow(clippy::undocumented_unsafe_blocks)]
 
 #[macro_use]
 extern crate log;
diff --git a/src/lib.rs b/src/lib.rs
index c605406238..d638caa8bc 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -34,20 +34,8 @@
 //! [`Context`]: struct.Context.html
 //! [`Context::receive_packet`]: struct.Context.html#method.receive_packet
 
+// Safety lints
 #![deny(bare_trait_objects)]
-#![allow(clippy::cast_lossless)]
-#![allow(clippy::cast_ptr_alignment)]
-#![allow(clippy::cognitive_complexity)]
-#![allow(clippy::needless_range_loop)]
-#![allow(clippy::too_many_arguments)]
-#![allow(clippy::verbose_bit_mask)]
-#![allow(clippy::unreadable_literal)]
-#![allow(clippy::many_single_char_names)]
-#![allow(clippy::wrong_self_convention)]
-#![allow(clippy::missing_safety_doc)]
-#![allow(clippy::comparison_chain)]
-#![allow(clippy::upper_case_acronyms)]
-#![allow(clippy::enum_variant_names)]
 // Performance lints
 #![warn(clippy::linkedlist)]
 #![warn(clippy::mutex_integer)]
@@ -57,15 +45,22 @@
 #![warn(clippy::mem_forget)]
 #![warn(clippy::path_buf_push_overwrite)]
 // Clarity/formatting lints
+#![allow(clippy::comparison_chain)]
+#![allow(clippy::enum_variant_names)]
 #![warn(clippy::map_flatten)]
 #![warn(clippy::mut_mut)]
 #![warn(clippy::needless_borrow)]
 #![warn(clippy::needless_continue)]
+#![allow(clippy::needless_range_loop)]
+#![allow(clippy::too_many_arguments)]
 #![warn(clippy::range_plus_one)]
+#![allow(clippy::upper_case_acronyms)]
 // Documentation lints
 #![warn(clippy::doc_markdown)]
 #![warn(clippy::missing_errors_doc)]
 #![warn(clippy::missing_panics_doc)]
+// FIXME: We should fix instances of this lint and change it to `warn`
+#![allow(clippy::missing_safety_doc)]
 
 // Override assert! and assert_eq! in tests
 #[cfg(test)]