From 7afcba77d2fe73a9a06ca69700fe4fd688406bde Mon Sep 17 00:00:00 2001 From: John Long Date: Tue, 21 May 2024 23:30:57 -0400 Subject: [PATCH] added omitempty to enabled bool to avoid accidental overwriting --- api/crds/kubefox.xigxog.io_platforms.yaml | 3 --- api/kubernetes/types.go | 3 +-- docs/reference/kubernetes-crds.md | 2 +- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/api/crds/kubefox.xigxog.io_platforms.yaml b/api/crds/kubefox.xigxog.io_platforms.yaml index e4eeec4..3e54442 100644 --- a/api/crds/kubefox.xigxog.io_platforms.yaml +++ b/api/crds/kubefox.xigxog.io_platforms.yaml @@ -4789,10 +4789,7 @@ spec: address: type: string enabled: - default: false type: boolean - required: - - enabled type: object logs: properties: diff --git a/api/kubernetes/types.go b/api/kubernetes/types.go index dc46db4..564ac19 100644 --- a/api/kubernetes/types.go +++ b/api/kubernetes/types.go @@ -100,8 +100,7 @@ type TelemetrySpec struct { } type CollectorSpec struct { - // +kubebuilder:default=false - Enabled bool `json:"enabled"` + Enabled bool `json:"enabled,omitempty"` Address string `json:"address,omitempty"` } diff --git a/docs/reference/kubernetes-crds.md b/docs/reference/kubernetes-crds.md index 1fc4189..46fcb76 100644 --- a/docs/reference/kubernetes-crds.md +++ b/docs/reference/kubernetes-crds.md @@ -294,7 +294,7 @@ Used by:
| Field | Type | Description | Validation | | ----- | ---- | ----------- | ---------- | -| `enabled` |
boolean
|
|
default: false
| +| `enabled` |
boolean
|
|
| | `address` |
string
|
|
|