-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapping code in component_editor outdated #95
Comments
Primitive snapping is maybe not that important as component snapping, so IMHO we could remove the primitive snapping from the component_editor |
Ok, removing the whole code here is also an option. |
If you agree... I think the users we are targeting don't wanted the automatic snapping tool anyway, and the "manual" snapping tool (picking list entries) just makes sense in the plant editor.. so if you agree, let's just remove the primitive snapping for now |
Yes, I agree... What about @tpaviot? |
Primitive snapping is actually something important (the PDMS "Psets" allow doing this). But I agree it's not that important for the coming demo. Component snapping, in the plant editor, is much more important. I'm ok for a temporary removal of primitive snapping, but it's something we have to keep in mind for the future. In the meantime, it should however be possible to rotate the primitives to ensure they're correctly placed (currently, AFAIK, only primitive translation is possible). |
There is also scale and rotation, you have switch the mode via the corresponding buttons in the top menu bar (though only via UI, same fields then as for translation). |
Thanks, I didn't notice this feature. I was confused by the fact that the parameters keep the same name X,Y and Z whether the selected mode is enabled. Other note: when switching to scale/rotate mode, any mouse move switches to translate mode. |
For mouse interaction, currently only translation is implemented, therefore this doesn't switch here... |
Completely remove primitive snapping or update to plant_editor version? In this regard, sharing common js files (cp. issue #90) between editors would be better to avoid such problems.
The text was updated successfully, but these errors were encountered: