Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency Issue in YarepGroup when adding new member #7

Open
baszero opened this issue Jan 24, 2019 · 0 comments
Open

Concurrency Issue in YarepGroup when adding new member #7

baszero opened this issue Jan 24, 2019 · 0 comments

Comments

@baszero
Copy link
Contributor

baszero commented Jan 24, 2019

For websites with high traffic the following method can cause concurrency issues (resulting in corrupt group.xml) as it is not synchronized:

public void addMember(Item item) throws AccessManagementException {

Possible solution:
The variable memberUserIDs should be created like this:

List<String> memberUserIDs = Collections.synchronizedList(new ArrayList<String>());

I suspect there are many locations in the Yanel code with similar concurrency issues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant