-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does not detect mime type or decode metadata on files from linx #13
Comments
|
There appears to be some sort of issue with the network request (URL redacted). When running liquidsoap with
I need to do some more testing, perhaps with a Linx instance that's not behind our auth proxy, but right now I'm thinking this may be due to some issue with SSO. |
Per discussion on slack, potentially a permutation of buzzfeed/sso#232 |
See also buzzfeed/sso#151 which has a better analysis of the problem, although the root cause is probably identical to buzzfeed/sso#232. |
Making some more progress on this, it seems Liquidsoap is doing a HEAD with the internal HTTP client first, which is failing, possibly due to not sending SNI. Running with
Note the Edit: Indeed. Fixed 5 days ago: savonet/liquidsoap#1304 |
We're running Liquidsoap v1.4.3-pre-release for now which should fix this. I'd like to do some testing before closing this out, though. |
Just confirmed with a FLAC file; seems to be working fine. If we continue to see problems with metadata on certain MP3 files, let's open a new issue. |
for mp3s, it correctly guesses MAD and tries (but fails) to log empty metadata. for flack, it fails do decode at all
The text was updated successfully, but these errors were encountered: