[4.5.0][FEATURE] Implement Labels Feature #12746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakshina99
requested review from
tharindu1st,
AnuGayan,
chamilaadhi,
Arshardh,
dushaniw and
tgtshanika
as code owners
dakshina99
changed the title
dakshina99
force-pushed
the
label-feature
branch
from
442a3c8 to
d95ce01
Compare
AnuGayan
requested changes
Jan 13, 2025
...imgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/APIAdminImpl.java
Outdated
Show resolved
Hide resolved
| @@ -4339,7 +4338,7 @@ public DocumentationContent getDocumentationContent(String apiId, String docId, | |||
| @Override | |||
| public String getAsyncAPIDefinitionForLabel(Identifier apiId, String labelName) throws APIManagementException { | |||
|
|
|||
| List<Label> gatewayLabels; | |||
| // List<Label> gatewayLabels; | |||
...mgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java
Show resolved
Hide resolved
dakshina99
force-pushed
the
label-feature
branch
from
d95ce01 to
5fb80a9
Compare
RakhithaRR
reviewed
Jan 13, 2025
| @@ -95,6 +95,8 @@ public enum ExceptionCodes implements ErrorHandler { | |||
| 409, "Cannot update API: %s:%s, due to the resources to remove are used by one or more API Products"), | |||
| API_CATEGORY_INVALID( | |||
| 900345, "The API category is invalid.", 400, " The API category is invalid for API: %s"), | |||
| API_LABEL_INVALID( | |||
There was a problem hiding this comment.
Shouldn't we use a different code here as labels and categories are used for two different purposes?
| return hostsWithSchemes; | ||
| } | ||
| // /** | ||
| // * Get gateway host names with transport scheme mapping. |
There was a problem hiding this comment.
Do we need this commented code?
| return null; | ||
| } | ||
|
|
||
| public Response labelsLabelIdDelete(String labelId, MessageContext messageContext) { |
There was a problem hiding this comment.
Shall we add operationId to the swagger definition and make the generated method names more readable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the backend functionality to introduce a Labels Feature. The key features and enhancements included in this implementation are:
Label Management:
Extensibility:
Resolves Label Feature api-manager#3503