Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock icon statues in Main Window #1

Open
wpx12011 opened this issue Apr 14, 2023 · 1 comment
Open

Lock icon statues in Main Window #1

wpx12011 opened this issue Apr 14, 2023 · 1 comment

Comments

@wpx12011
Copy link
Owner

wpx12011 commented Apr 14, 2023

image.png

When first navigate to a record in the Main Window, the Contact Detail section will show an open lock with all contact details.

image.png

Click the icon once will hide all details but still show an open lock

image.png

Click it once more it will show details again with a locked icon. This is confusing, should change the default status of the icon to locked.

@nus-pe-script
Copy link

nus-pe-script commented Apr 17, 2023

Team's Response

The intuition of the lock icon should make sense as it implies the action of the button, not the current state.

This is similar to the iPhone lock screen and mute icon:

Example:

The icon Lock Rotation does not mean your phone is currently locked, the icon rather represents the action you want to do. So click on the Lock Rotation icon will lock your screen (i.e. you cannot rotate your screen).
image.png.

After clicking on the Lock Rotation button, it will change to Unlock Rotation icon.

image.png

However, your phone screen rotation is actually currently "locked" - the Unlock Rotation represents the "next" action you may want to do to change your phone to "unlocked" rotation, not the current state of your screen rotation.

We decided to use the same logic for our app as we feel that this is quite intuitive - it has been proven by the common use in Apple devices.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: The team is not answering to my issue raised. I am not talking about the logic between action and icon, but I'm suggesting that there is a display bug in the icon.

In my original issue description, I showed 3 screenshots which depicts 3 actions:

  1. When the app is first open, the default display shows contact detail and an open lock.
  2. When I click the lock icon once, the display hides contact details, but still showing an open lock.
  3. When I click the lock icon once more, the display shows contact details and a locked lock.

The team is trying to explain that the lock icon is behaving correctly in steps 2 and 3 (which I agree), but my actual issue is about the display bug in step 1. Therefore, I do not agree with the team's rejection.


❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: Please refer to my reasoning in response to reclassification of severity, I think this issue is a functionality bug since it's an incorrect behavior.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants