✨feat(grid): click on a blank space to deselect #WIK-16181 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Maple13
commented
Aug 2, 2024
•
Maple13
commented
- use textarea to support text editing and limit the height
- click on a blank space to deselect - use textarea to support text editing and limit the height
huanhuanwa
reviewed
Aug 2, 2024
| @@ -64,5 +64,9 @@ export class AITableGridSelectionService { | |||
| const fieldId = colDom.getAttribute('fieldId'); | |||
| fieldId && this.selectField(fieldId); | |||
| } | |||
|
|
|||
| if (!cellDom && !colDom) { | |||
| this.clearSelection(); | |||
There was a problem hiding this comment.
这里如果点击到的是行前方的复选框，清空是不是就有问题了
There was a problem hiding this comment.
没问题，document 的 mousedown 先执行，这时取消选中，然后执行复选框的 mousedown，又选上了
# Conflicts: # packages/grid/src/components/cell-editors/text/text-editor.component.ts # packages/grid/src/services/event.service.ts
- use textarea to support text editing and limit the height
Maple13
changed the title
huanhuanwa
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.