✨feat(grid): support progress editor #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Maple13
commented
Jul 31, 2024
Maple13
commented
- support hover pop-up editing component
- support hover pop-up editing component
# Conflicts: # src/app/app.component.ts
huanhuanwa
reviewed
Aug 2, 2024
packages/grid/src/components/cell-editors/progress/progress-editor.component.ts
Outdated
Show resolved
Hide resolved
| const cellDom = (event.target as HTMLElement).closest('.grid-cell') as HTMLElement; | ||
| const type = cellDom && (cellDom.getAttribute('type')! as AITableFieldType); | ||
| if (type && MOUSEOVER_EDIT_TYPE.includes(type)) { | ||
| this.mouseoverRef = this.openEdit(cellDom); |
There was a problem hiding this comment.
使用 mouseover 来关闭弹框，移入到其他单元格或其他grid位置，就认为需要之前打开的编辑。
所以没有使用 mouseout 单独处理关闭逻辑。
Maple13
force-pushed
the
maple13/#WIK-16107
branch
2 times, most recently
from
e5fc20a to
066af15
Compare
huanhuanwa
approved these changes
Aug 2, 2024
packages/grid/src/grid.component.ts
Outdated
| } | ||
|
|
||
| private closeHoverCellEditor(e: MouseEvent) { | ||
| const hasGrid = e.target && (e.target as HTMLElement).closest('.ai-table-grid'); |
There was a problem hiding this comment.
这里可以先判断 this.mouseoverRef 是不是打开的，打开的情况下再去查询，可以减少查询次数
Maple13
force-pushed
the
maple13/#WIK-16107
branch
from
066af15 to
9d81ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.