feat(action): add aiPlugin #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huanhuanwa
reviewed
Jul 25, 2024
| } | ||
|
|
||
| export interface AIViewTable extends AITable { | ||
| viewApply: (action: AIViewAction) => void; |
There was a problem hiding this comment.
扩展里应该包含 view 和 viewApply
src/app/types/view.ts
Outdated
| } | ||
|
|
||
| export enum ViewActionName { | ||
| updateRowHeight = 'update_row_height' |
There was a problem hiding this comment.
这里不需要 updateRowHeight ，统一用 set_view 修改 view 中的属性
涉及到修改的，需要保存前一个值:
export interface AIViewAction {
type: ViewActionName.SetView;
view: AITableView;
newView: AITableView;
path: [number];
}
src/app/action/view.ts
Outdated
| import { AITableView, ViewActionName } from '../types/view'; | ||
| import { AIViewTable } from '../types/view'; | ||
|
|
||
| export function updateRowHeight(aiTable: AIViewTable, view: AITableView, key: string, value: any) { |
There was a problem hiding this comment.
- 函数名为 setView
- 这个函数应该接收的值为 aiTable， newView 以及 path，在函数内部构建 AIViewAction
src/app/action/view.ts
Outdated
| } | ||
|
|
||
| export const applyView = (aiTable: AITable, options: any) => { | ||
| const view = options.view; |
There was a problem hiding this comment.
修改 view 时，应该和 records 和 fields 一样，通过 signal 的方式修改。参考 GeneralActions.transform
huanhuanwa
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.