Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to v2 endpoints #72

Open
iandunn opened this issue Mar 30, 2017 · 4 comments
Open

Migrate to v2 endpoints #72

iandunn opened this issue Mar 30, 2017 · 4 comments

Comments

@iandunn
Copy link

iandunn commented Mar 30, 2017

The V1 endpoints are now deprecated, and will be disabled in 1 year, on 2018-04-01.

Here are the new endpoints:

If you want speakers embedded in session responses, or vice-versa, you can append the ?_embed parameter, and then pull them from the _embedded field. The API handbook has details.

Let me know if you have any questions or run into any problems with the API.

aagam-shah added a commit to aagam-shah/WordCamp-Android-1 that referenced this issue Jul 17, 2017
@iandunn
Copy link
Author

iandunn commented Nov 20, 2017

@aagam-shah, it looks like you might already have this working, but I don't see a PR for it. Is it ready to send a PR, or does it need more work?

@aagam-shah
Copy link
Contributor

@iandunn - I had started but have left in-between. Will work on it and raise the PR as soon as it's ready

@GaryJones
Copy link

The date for disabling the v1 endpoints has passed, though are still active right now.

In relation to #73, I believe that the current query of pulling the last 50 WCs, ordered by ID is flawed, and a slightly different approach is needed when switching to the v2 endpoints.

The v2 endpoint has event start and end date fields:

screenshot 2018-05-15 10 18 12

Each refresh should, over one or more requests, order by the start or end date, and keep retrieving more entries until the end date of an event is earlier than the current date (no point in storing WCs that finished yesterday or earlier).

This will then capture events like WC Europe 2018, which has a low ID (registered early on), but whose start/end date is coming soon.

@GaryJones
Copy link

#74 appears to be a PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants