Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /proc/<PID>/task/<PID>/maps as a fast-path for /proc/<PID>/maps #9

Open
woodruffw opened this issue Jan 18, 2022 · 1 comment
Open

Use /proc/<PID>/task/<PID>/maps as a fast-path for /proc/<PID>/maps #9

woodruffw opened this issue Jan 18, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@woodruffw
Copy link
Owner

Apparently the former doesn't include task stacks and therefore doesn't have to scan every thread in the process ID's thread group. Users generally don't want task stacks often, so this is a reasonable maps file to consider instead.

In particular, from_pid can probably learn a second argument, something like ThreadStackPolicy::{Include,Exclude}.
@woodruffw woodruffw added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 18, 2022
@woodruffw
Copy link
Owner Author

N.B.: We should actually benchmark that alternate path first, since the codebase (GDB) that claims it's faster made that claim at least a decade ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@woodruffw