Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brands section on the Storefront Homepage template #2183

Open
2 tasks done
OmarFPG opened this issue Jan 23, 2025 · 1 comment
Open
2 tasks done

Brands section on the Storefront Homepage template #2183

OmarFPG opened this issue Jan 23, 2025 · 1 comment
Labels
priority: normal The issue/PR is low priority—not many people are affected or there’s a workaround, etc.

Comments

@OmarFPG
Copy link

OmarFPG commented Jan 23, 2025

Describe the bug

With the inclusion of Brands in WooCommerce core, the "Homepage" template from the Storefront theme now includes a Brand section at the bottom by default; this shows up even if it's empty.

This is currently showing up even if it's empty.

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and themes and confirmed this bug occurs when only WooCommerce + Storefront theme are active.
  • I can reproduce this bug consistently using the steps below.

To Reproduce

Steps to reproduce the behavior:

  1. Install Storefront
  2. Set up a home page using the "Homepage" template
  3. Install WooCommerce 9.6 or above

Screenshots

Image

Image

Expected behavior

The Brands section shouldn't appear if no Brands have been published in the store yet (similar to how the other sections work!).
A small suggestion on top of it: an option on the customizer could be included to enable this section at will

Workaround

A small CSS snippet to hide this section can work meanwhile:

section.storefront-product-section.storefront-woocommerce-brands {
    display: none;
}

WordPress Environment

Tested on a clean site with JN: https://substantial-cat.jurassic.ninja/

@wyter
Copy link

wyter commented Jan 24, 2025

First reported on 9302789-zen

@WunderBart WunderBart added priority: normal The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: cooldown Things that are queued for a cooldown period (assists with planning). and removed type: cooldown Things that are queued for a cooldown period (assists with planning). labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal The issue/PR is low priority—not many people are affected or there’s a workaround, etc.
Projects
None yet
Development

No branches or pull requests

3 participants