New component - PieChart #3470
Merged
New component - PieChart #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nitzanyiz |
|
@ethanshar I think I need to rethink the api. When I started to use the component I got into a few problems with the api. Lets discuss this. |
ethanshar
reviewed
Jan 8, 2025
|
@ethanshar , I made all the changes and added some to the api (border width and color). Also I added the api json. |
|
@nitzanyiz looks good, see my replies - left few small things. Ping me on slack when it's ready and I'll approve |
ethanshar
approved these changes
Jan 22, 2025
src/components/pieChart/index.tsx
Outdated
Comment on lines
25
to
27
| if (!Svg || !Path) { | ||
| console.error(`RNUILib PieChart requires installing "@react-native-svg" dependency`); | ||
| } |
There was a problem hiding this comment.
Let's return here null after showing the error to avoid an actual exception that might crash the whole screen or tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new component PieChart. The component gets segments which is an array of percentages to that each segment of the pie should cover. Each segment is a percentage representing the percentage of the pie to cover and a color for the pie segment.
Changelog
⭐ PieChart - New Component ⭐
Additional info
MADS-3418