Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve astro:env config error #12912

Merged
merged 6 commits into from
Jan 8, 2025
Merged

feat: improve astro:env config error #12912

merged 6 commits into from
Jan 8, 2025

Conversation

florian-lefebvre
Copy link
Member

Changes

  • Improves the config error for invalid combinations of context and access properties under env.schema

Testing

Added test

Docs

N/A

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 6, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12912 will not alter performance

Comparing feat/improve-astroenv-config-error (62638df) with main (ad2a752)

Summary

✅ 6 untouched benchmarks

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7a505a6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sarah11918
sarah11918 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no secret, I'm approving for docs!

@florian-lefebvre florian-lefebvre merged commit 0c0c66b into main Jan 8, 2025
16 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/improve-astroenv-config-error branch January 8, 2025 13:29
@astrobot-houston astrobot-houston mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florian-lefebvre @ematipico @sarah11918 @bluwy