Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(i18n): fix typo in fallbackType JSDoc comment #11870

Conversation

ArmandPhilippot
Copy link
Member

@ArmandPhilippot ArmandPhilippot commented Aug 29, 2024

Changes

The example provided for i18n.routing.fallbackType was using the wrong filename (dist/en/index.html should be dist/en/about.html since the page is src/pages/en/about.astro).

Testing

No need.

Docs

  • No additional documentation needed, this is a small fix in i18n.routing.fallbackType documentation
  • I added a changeset since this fixes the documentation content

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 013527f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Aug 29, 2024
@ArmandPhilippot ArmandPhilippot marked this pull request as draft August 29, 2024 12:39
@ArmandPhilippot ArmandPhilippot force-pushed the docs/fix-typo-i18n-routing-fallbackType branch from 5eb847b to 013527f Compare August 29, 2024 12:41
@ArmandPhilippot ArmandPhilippot marked this pull request as ready for review August 29, 2024 12:41
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast, thank you :)

@ematipico ematipico merged commit 8e5257a into withastro:main Aug 30, 2024
14 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Aug 30, 2024
@ArmandPhilippot ArmandPhilippot deleted the docs/fix-typo-i18n-routing-fallbackType branch August 30, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants