Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare Adapter warning is useless when using server islands #493

Open
1 task done
DeJayDev opened this issue Dec 31, 2024 · 1 comment
Open
1 task done

Cloudflare Adapter warning is useless when using server islands #493

DeJayDev opened this issue Dec 31, 2024 · 1 comment

Comments

@DeJayDev
Copy link

Astro Info

Astro                    v5.1.1
Node                     v22.12.0
System                   Linux (x64)
Package Manager          npm
Output                   static
Adapter                  @astrojs/cloudflare
Integrations             astro-icon

Describe the Bug

The @astrojs/cloudflare warning:
This adapter is intended to be used with server rendered pages, which this project does not contain any of. As such, this adapter is unnecessary.

Does not take into consideration if server islands are enabled at all.

What's the expected result?

Ideally, this warning doesn't appear - it should be possible to just check for serverIslands?

Link to Minimal Reproducible Example

I tried to make an example on all the providers listed by astro.new and none of them worked. Sorry.

Participation

  • I am willing to submit a pull request for this issue.
@DeJayDev
Copy link
Author

DeJayDev commented Dec 31, 2024

If this is as easy as adding && !config.serverIslands to here:

if (buildOutput === 'static') {

I can just do it myself. Terribly sorry I couldn't provide a repro none of these services ever work. I could make a repo locally but it feels like a lot of effort to mute an erroneous warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant