Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive component loader: Lazy loading with preloadAllModules strategy causing load loop (?) #214

Open
olofens opened this issue Nov 16, 2020 · 2 comments

Comments

@olofens
Copy link

olofens commented Nov 16, 2020

Just wanted to let others that might be in the same situation know that Reactive component loader doesn't seem to work with preloadingStrategy: preloadAllModules. At least for me disabling this strategy instantly fixed my issue, which was that the page just would load infinitely / become unresponsive. The strategy was likely causing some infinite loop.

Will come back here and try to create a minimal reproduction when I find the time.

@yjaaidi
Copy link
Contributor

yjaaidi commented Nov 18, 2020

Oh! Interesting.
I'll try to check that out as soon as I can if you don't provide a repro before 😊

@olofens
Copy link
Author

olofens commented Nov 20, 2020

Really great to see that you are still active within this repo. I will work on creating some different reproductions for this package this weekend. I really like it and can't find anything else that can load modules/features dynamically. On the subject of this thread here, have a look at this file, line 40: https://github.com/wishtack/wishtack-steroids/blob/master/packages/reactive-component-loader/src/lib/reactive-component-loader.module.ts

There this problem I mention above is described and solved? I saw this after I just decided to disable preloadAllModules however, so I never got to try it. If it does work, it should be documented somewhere more obvious, though :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants