Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support wasm debug trace log #493

Closed
wants to merge 1 commit into from
Closed

support wasm debug trace log #493

wants to merge 1 commit into from

Conversation

baoyachi
Copy link
Contributor

@baoyachi baoyachi commented Mar 3, 2024

fix #430

#[cfg(feature = "debug-wasm")]
{
let mut writer = debug_wasm::TRACE_LOG.lock().unwrap();
writer.push(f)

Check failure

Code scanning / clippy

borrow of moved value: f Error

borrow of moved value: f
{
let writer = anstream::stderr();
let mut writer = writer.lock();
let _ = writeln!(writer, "{}", f);

Check failure

Code scanning / clippy

borrow of moved value: f Error

borrow of moved value: f
}
}

fn writer_in(f: String) {

Check failure

Code scanning / clippy

borrow of moved value: f Error

borrow of moved value: f
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 41.88%. Comparing base (85d4933) to head (033d60a).

Files Patch % Lines
src/combinator/debug/internals.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   41.84%   41.88%   +0.04%     
==========================================
  Files          18       18              
  Lines        3047     3044       -3     
==========================================
  Hits         1275     1275              
+ Misses       1772     1769       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8130788714

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 41.886%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/combinator/debug/internals.rs 0 7 0.0%
Totals Coverage Status
Change from base Build 8101851502: 0.04%
Covered Lines: 1275
Relevant Lines: 3044

💛 - Coveralls

@epage
Copy link
Collaborator

epage commented Mar 4, 2024

@baoyachi
Copy link
Contributor Author

baoyachi commented Mar 4, 2024

So, What better ideas do you have for adapting wasm with debug tracing?

@epage
Copy link
Collaborator

epage commented Mar 4, 2024

So, What better ideas do you have for adapting wasm with debug tracing?

Like I said, I only looked at this enough to know this was not in a state to look at, so I can't say much more about this solution.

Might be good to post your proposal in the issue for us to discuss. Overall, this is not a priority for me, so I won't have much time to put to discussing this.

@baoyachi baoyachi closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm-pack build error when use winnow debug feature
3 participants