-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support wasm debug trace log #493
Conversation
#[cfg(feature = "debug-wasm")] | ||
{ | ||
let mut writer = debug_wasm::TRACE_LOG.lock().unwrap(); | ||
writer.push(f) |
Check failure
Code scanning / clippy
borrow of moved value: f Error
{ | ||
let writer = anstream::stderr(); | ||
let mut writer = writer.lock(); | ||
let _ = writeln!(writer, "{}", f); |
Check failure
Code scanning / clippy
borrow of moved value: f Error
} | ||
} | ||
|
||
fn writer_in(f: String) { |
Check failure
Code scanning / clippy
borrow of moved value: f Error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
==========================================
+ Coverage 41.84% 41.88% +0.04%
==========================================
Files 18 18
Lines 3047 3044 -3
==========================================
Hits 1275 1275
+ Misses 1772 1769 -3 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 8130788714Details
💛 - Coveralls |
|
So, What better ideas do you have for adapting wasm with debug tracing? |
Like I said, I only looked at this enough to know this was not in a state to look at, so I can't say much more about this solution. Might be good to post your proposal in the issue for us to discuss. Overall, this is not a priority for me, so I won't have much time to put to discussing this. |
fix #430