-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Foliate as a .deb package from GitHub instead of PPA #685
Comments
I was going to make a PR to change this to the Github release, but it doesn't actually install on Bookworm due to depending on a newer version of gir1.2-gtk-4.0. |
When Trixie is released, Foliate will be stuck again at the current version for the next two years, so I suppose adding it to deb-get still will be useful. |
It looks like Focal and Jammy also lack the needed dependencies, so if we switch to the Github method, we will lose support for those too. (Presumably the dependencies were included in the PPA.) Alternatively, maybe we could use the "website" method and just download the debs directly from Launchpad or Github depending on whether the system is Debian or Ubuntu. I don't know if there would be any issue treating Github like just another website and not going through the API, though. |
I'm not a fan of having a GitHub source and a PPA source treated as a web source. But we can (have) chose appropriate source based on the host OS where that benefits users. I wouldn't want to de-support jammy users, and particularly not just to introduce support for Trixie/Sid where Bookworm is not supported. I would like to add support via GitHub releases for Debians and derivatives that can be so supported. |
It seems like you're saying it's okay to have different installation methods in a single package, but I was previously told not to do that. Is the prettylist thing mentioned in #521 not an issue anymore? Just trying to wrap my head around seemingly conflicting information.
Originally posted by @natanjunges in #521 (comment)
Originally posted by @flexiondotorg in #521 (review) |
@silentJET85 you are correct - my opinion now, given the current circumstances and the discussion around this package, differs from that held by natan and @flexiondotorg regarding #521. It is true that that output of I'll try and create another PR myself for the split source approach and arrange for either merge to close the other so @flexiondotorg can comment or make the choice between
|
I agree with you. Option 3 seems best. In doing some more testing, I've found that this won't always install on Sid because of #674. |
App is already available from deb-get but is sourced from PPA, which makes it impossible to install it on non-Ubuntu distros. Switching to a .deb package would make it available for all Debian based distros, not only *buntus.
The text was updated successfully, but these errors were encountered: