Pagination Doesn't Wrap Around Pages After Device Rotation

[rhsalas3]

Description:

Assuming more than one page on a screen, pagination controls allow users to wrap around from the last page to the first page regardless of using the right or left page buttons. However, there is a use case whereby the pagination does not follow that behavior. When the device is in Portrait orientation and that screen is at 1 page, and the device is rotated to Landscape so that there are 2 pages, then you cannot wrap around from the first page to the last with the arrows.

04/29/2022 Edit:
Same behavior occurs on main screen for both preset and custom categories. When categories has nine phrases on iPad, if we rotate the device from Portrait to Landscape, right and left arrows are not warping properly (Screen Recording 2).

Steps to Reproduce:

1. While your device's orientation is Portrait
2. Create a custom category
3. Add 3 phrases...remain on the Edit Phrases screen
4. Note the pagination controls for 1 page; buttons disabled
5. Rotate the device to be in Landscape
   • there should now be 2 pages instead of 1

Expected behavior
Now the arrows are enabled. Using the right arrow I can navigate to page 2 and then again to wrap around back to page 1. It is expected that you can do the same with the left arrow. To demonstrate: 1 -> 2 -> 1 and conversely 1 <- 2 <- 1

Actual behavior
Now the arrows are enabled but, using the right arrow to navigate, once you get to page 2 you cannot wrap around back to page 1. It is the same errant behavior with the left arrow.

Screen Recording 1

Rotating_editPhrasesScreen_paginationDoesNotWrap.mp4

Device Information

• Device: iPhone 12 (simulator)
• OS: iOS 15.4

Screen Recording 2

MainScreenMySayingsPagination.mov

Device Information

• Device: iPad Pro (test device)
• OS: iOS 15.3.1

[rhsalas3]

@rowildcard

Here is the second of the 2 bugs we found when pairing on the pagination fixes.

[rhsalas3]

After disabling animations we found that some tests are failing due to this bug (which seems more exposed now w/ animations off). We opted to just disable the affected tests. Once this bug is fixed then we will re-enable them.

Test affected:
MainScreenPaginationTests::testCanScrollPagesWithPaginationArrows()

Related bug:
#597