Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS binary? #4

Open
muuuh opened this issue Jan 25, 2024 · 3 comments
Open

MacOS binary? #4

muuuh opened this issue Jan 25, 2024 · 3 comments

Comments

@muuuh
Copy link

muuuh commented Jan 25, 2024

Thanks for your plugin!

Could you please provide a binary for macOS?

I use the nightly build but miss DAB+. There seems to be a build guide for sdrplusplus https://github.com/AlexandreRouma/SDRPlusPlus?tab=readme-ov-file#building-on-macos but I currently have no idea how to build the module for macos https://github.com/FiendChain/SDRPlusPlus-DAB-Radio-Plugin/tree/master/toolchains

MacOS seems to require a .dylib file, like others in /Applications/SDR++.app/Contents/Plugins

Best regards,

Edit: Sorry, I just tested https://www.welle.io/ and that seems to be enough for my purposes :)

@muuuh muuuh changed the title Macos? MacOS binary? Jan 25, 2024
@muuuh muuuh closed this as completed Jan 25, 2024
@williamyang98
Copy link
Owner

williamyang98 commented Feb 9, 2024

For any future macOS users you can follow the steps here: macos.yml. After building the plugin the dab_plugin.dylib file should be in your build folder. If there are any problems related to macos compiling, feel free to leave them here.

@williamyang98 williamyang98 reopened this Feb 10, 2024
@muuuh
Copy link
Author

muuuh commented Feb 12, 2024

Thank you very much!

I was able to compile a libdab_plugin.dylib with Apple Silicon/arm64, but had no success activating the plugin in the SDR++ module manager (list next to the + button).

I'm currently stuck at this point and would expect a crash if the SDR++ core library differs from the dab plugin. I haven't noticed any hints in the macos console app for the process sdrpp, but not sure where SDR++ logs most (there are some logs for proces sdrpp in the console app).

Steps:

git clone --recurse-submodules https://github.com/FiendChain/SDRPlusPlus-DAB-Radio-Plugin
cd SDRPlusPlus-DAB-Radio-Plugin
cd vendor/volk
cmake . -B build -DCMAKE_OSX_DEPLOYMENT_TARGET="10.15" -DCMAKE_BUILD_TYPE=Release -G Ninja

Because of google/cpu_features#204 (comment) I had to use https://github.com/google/cpu_features/tree/c5ece5e8ccd64f0da935fceb14f9ab8a3e2eefa0 and replaced the existing folder in ./vendor/volk/cpu_features/ with

git clone https://github.com/google/cpu_features/tree/
git checkout c5ece5e8ccd64f0da935fceb14f9ab8a3e2eefa0

Afterwards I could compile:

sudo cmake --build build --config Release --target install
cd ..
mkdir build-macos
cmake . -B ./build-macos -DCMAKE_OSX_DEPLOYMENT_TARGET="10.15" -DCMAKE_BUILD_TYPE=Release -G Ninja
cmake --build ./build-macos --config Release --target dab_plugin

I used the nightly build for Apple Silicon/arm64 referenced at AlexandreRouma/SDRPlusPlus#557 (comment) and copied ./build-macos/src/libdab_plugin.dylib to /Applications/SDR++.app/Contents/Plugins/libdab_plugin.dylib.

I'll let you know if there is progress. Thank you!

@boybook
Copy link
Contributor

boybook commented Apr 13, 2024

@muuuh I tried it, and it worked! #5
Download: https://github.com/boybook/SDRPlusPlus-DAB-Radio-Plugin/actions/runs/8673954356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants