Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block (domain) no longer working. #47

Open
MarjaE2 opened this issue Aug 13, 2020 · 2 comments
Open

Block (domain) no longer working. #47

MarjaE2 opened this issue Aug 13, 2020 · 2 comments

Comments

@MarjaE2
Copy link

MarjaE2 commented Aug 13, 2020

I can click and click, but just get "javascript:;" I closed and reopened Firefox, but it's still stuck.

Is there a limit on the number of unwanted domains? Currently 329.

@DreamPhreak
Copy link

Came here to post the same thing, it seems there is a limit. Once I hit 403, I cannot block any more. I confirmed this by unblocking 1, then it let me block 1 like normal, but I still couldn't block any more after that. Stuck at 403.

@dgoffredo
Copy link

It might be due to a Promise error here. I expect that would throw an exception, but maybe not.

browser.storage.sync has a per-extension size limit. .set(...) sends an error to its returned Promise if the limit is reached. If the issue is the size limit being reached, then that would explain why we all have different numbers of blocked domains hitting the limit: the length of the individual domains vary.

I tried to add some logging to my installed copy of the extension, but firefox won't accept it. I don't have a developer build of firefox and haven't ever done browser add-on development.

Maybe I'll look into it more sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants