Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify access levels to allow more flexible subclassing #139

Closed
attheodo opened this issue Apr 24, 2020 · 2 comments
Closed

Modify access levels to allow more flexible subclassing #139

attheodo opened this issue Apr 24, 2020 · 2 comments

Comments

@attheodo
Copy link

Problem description

WSTagsFields API for the most part is open to modifications by exposing most of it's methods as public. However for better leveraging the core functionality of the library, and especially providing custom tokenization by overriding tokenizeTextFieldText(), the textField property needs to be made public. Consequently the BackSpaceDetectingTextField() needs to be accessible outside of the module.

Preferred solution

Make the above properties and class public.

@ricardopereira
Copy link
Member

The WSTagsField.textField has been exposed for public access in v5.3. Thanks for the issue.

@attheodo
Copy link
Author

attheodo commented May 2, 2020

Thank you for the effort man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants