Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Use pytest-datadir to manage data files for tests #34

Open
wfondrie opened this issue Jul 15, 2021 · 2 comments
Open

[Upgrade] Use pytest-datadir to manage data files for tests #34

wfondrie opened this issue Jul 15, 2021 · 2 comments

Comments

@wfondrie
Copy link
Owner

@jspaezp suggested switching over to pytest-datadir for managing our test data. This would have the benefit of simplifying our test fixtures, making it easier for folks to contribute. The user impact of this change is minimal, but it does add an additional developer dependency.

I think this change is probably worth making.

@jspaezp
Copy link
Collaborator

jspaezp commented Jul 26, 2021

I think i could tackle this issue but I feel like the cross linking PSMs PR should be solved first ... but if you want to set that aside and re-base it with the new test stuff i could go ahead and start the changes.

Best!
Sebastian

@wfondrie
Copy link
Owner Author

Unfortunately, cross-linking support has been kicked down the road a bit, so you shouldn't worry about. If you want to tackle the test conversion to pytest-datadir, please feel free to go ahead!

sambenfredj referenced this issue in msaid-de/mokapot Apr 12, 2023
deduplication flag

Closes #34

See merge request msaid/chimerys/mokapot!38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants