-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce custom reporters (poku
, dot
, compact
, focus
, verbose
, and classic
)
#921
Draft
wellwelwel
wants to merge
24
commits into
main
Choose a base branch
from
reporter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,482
−724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
==========================================
+ Coverage 99.04% 99.27% +0.22%
==========================================
Files 37 47 +10
Lines 1884 2337 +453
Branches 12 13 +1
==========================================
+ Hits 1866 2320 +454
+ Misses 9 8 -1
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #629.
🚧 WIP: This is probably the most significant refactoring of the entire project.
This PR introduces 6 reporters:
poku
(default):describe
,it
,test
andassert
titles and messages, including their modifiers.dot
(inspired by Mocha):F
for each failed file.compact
(inspired by modern Tap):PASS
orFAIL
and, in case of failures, lists all logs for each failed file at the running end.focus
:verbose
:poku
), but logs errors in real time and also at the running end.classic
:⏳ Progress:
Note
I intend to expose the plugin to allow external reporters to be created, but I think it would be interesting to decouple this responsibility into its own PR.