Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The separator line keep visible when context is toggle off #142

Open
vds2212 opened this issue Jul 11, 2024 · 3 comments
Open

The separator line keep visible when context is toggle off #142

vds2212 opened this issue Jul 11, 2024 · 3 comments

Comments

@vds2212
Copy link
Contributor

vds2212 commented Jul 11, 2024

I'm using:

  • gVim 9.1.474 on Windows 10 and
  • Neovim 0.10 on Windows 10

On both I have the same problem with the version of the 10th of July.

Remark:

  • The version of 1st of July, commit: 5d14952, seems to work fine
  • It seems that the commit: f8f619e is the one that induces the behavior

When I toggle context.vim off using the :ContextToggle command the context separator line is not removed like it was before the new release of the 10 of July 2024.

Before 10th of July with context.vim activate:
image
Before 10th of July with context.vim deactivate (:ContextToggle)
image

After 10th of July with context.vim activate:
image
After 10 of July with context.vim deactivate (:ContextToggle) and any cursor motion (l, h, ...)
image

After 10th of July:

  • The separator line doesn't go to the margin (good or not could be discussed).
  • When toggle off the separator line stay and the context stay (a bit like it is not off)

It can be reproduced with any kind of file.
Here is the file I use for the screenshot in case it helps.

class Hello:
    def __init__(self):
        print("hello")

    def hello(self, message):
        if message:
            print(message)
        else:
            print("hello")

class Foo:
    def __init__(self):
        print("foo")

    def hello(self, message):
        if message:
            print(message)
        else:
            print("hello")
@GregShiner
Copy link

Same issue here. Trying :ContextDisable makes it flash off then back on. I suspect theres something automatically enabling it all the time, and the issue is not that its not disabling.

vds2212 added a commit to vds2212/context.vim that referenced this issue Jul 12, 2024
wellle added a commit that referenced this issue Jul 19, 2024
@wellle
Copy link
Owner

wellle commented Jul 19, 2024

Thank you. Could you check again now, please?

@vds2212
Copy link
Contributor Author

vds2212 commented Jul 20, 2024

Thank you for merging the changes. I just started my holidays :-/ I'll check when I'll be back probably around 12th of August

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants