Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Late Provider: Handle unfulfilled Context Requests to handle Issues with Load Time & late Element definition #87

Closed
quarkus opened this issue Mar 2, 2023 · 0 comments · Fixed by #92
Closed

Late Provider: Handle unfulfilled Context Requests to handle Issues with Load Time & late Element definition #87

quarkus opened this issue Mar 2, 2023 · 0 comments · Fixed by #92
Assignees
@quarkus
Labels
enhancement New feature or request

Comments

@quarkus
Copy link
Contributor

quarkus commented Mar 2, 2023 •
edited
Loading

An idea wuld be to collect the requests on an global level and retrigger them at some time:

Lit does sth as well.
https://github.com/lit/lit/tree/main/packages/labs/context

There is an issue in the protocol as well:
webcomponents-cg/community-protocols#25

Where do we place / ship the global logic for the pooling !?

EDIT:

Easiest way is probably to retrigger the requests here:

element-js/src/BaseElement.js

Line 327 in 5ae7e17

definePropertyInjection() {

@quarkus quarkus self-assigned this Mar 2, 2023
@quarkus quarkus changed the title Collect unhandled Context Requests to tackle Load Time & Element definition issues Late Provider: Handle unfulfilled Context Requests to handle Issues with Load Time & late Element definition Mar 3, 2023
@quarkus quarkus added the enhancement New feature or request label Mar 3, 2023
quarkus added a commit that referenced this issue Mar 7, 2023
@quarkus
fix(injection): #87 adds late injection through replaying the request…
8d99593 
…s when a provider getx defined after a requesting child
@quarkus quarkus linked a pull request Mar 7, 2023 that will close this issue
fix(injection): #87 adds late injection through replaying the request… #92
Merged
quarkus added a commit that referenced this issue Mar 9, 2023
@quarkus
feat(injection): #87 fix root for shadow Dom support
ce1e4c5
quarkus added a commit that referenced this issue Mar 17, 2023
@quarkus
feat(injection): #87 externalize BaseElement Filter to get rid of cir…
6b75881 
…cular dependency
quarkus added a commit that referenced this issue Mar 17, 2023
@quarkus
feat(injection): #87 externalize instanceOf checks everywhere as they…
3d740d4 
… might cause cyclic structures
quarkus added a commit that referenced this issue Mar 17, 2023
@quarkus
feat(injection): #87 externalize instanceOf checks everywhere as they…
8855fbe 
… might cause cyclic structures
quarkus added a commit that referenced this issue Sep 19, 2023
@quarkus
fix(injection): #87 adds late injection through replaying the request…
d750b50 
…s when a provider getx defined after a requesting child
quarkus added a commit that referenced this issue Sep 19, 2023
@quarkus
feat(injection): #87 fix root for shadow Dom support
a23b7b0
quarkus added a commit that referenced this issue Sep 19, 2023
@quarkus
feat(injection): #87 externalize BaseElement Filter to get rid of cir…
26e8203 
…cular dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quarkus quarkus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(injection): #87 adds late injection through replaying the request… webtides/element-js
1 participant
@quarkus