From 7f533c8a1b8a69eebe2b760c9d71fdcc05a3dc38 Mon Sep 17 00:00:00 2001 From: John Berlin Date: Tue, 19 Feb 2019 18:15:27 -0500 Subject: [PATCH] removed the mutable default value for warc_header_dict keyword arg in BaseWARCWriter:create_revisit_record and BaseWARCWriter:create_warc_record (#70) --- warcio/warcwriter.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/warcio/warcwriter.py b/warcio/warcwriter.py index 3dbdc38c..f8e6d504 100644 --- a/warcio/warcwriter.py +++ b/warcio/warcwriter.py @@ -167,9 +167,11 @@ def create_warcinfo_record(self, filename, info): length=length) def create_revisit_record(self, uri, digest, refers_to_uri, refers_to_date, - http_headers=None, warc_headers_dict={}): + http_headers=None, warc_headers_dict=None): assert digest, 'Digest can not be empty' + if warc_headers_dict is None: + warc_headers_dict = dict() record = self.create_warc_record(uri, 'revisit', http_headers=http_headers, warc_headers_dict=warc_headers_dict) @@ -187,9 +189,11 @@ def create_warc_record(self, uri, record_type, payload=None, length=None, warc_content_type='', - warc_headers_dict={}, + warc_headers_dict=None, warc_headers=None, http_headers=None): + if warc_headers_dict is None: + warc_headers_dict = dict() if payload and not http_headers: loader = ArcWarcRecordLoader()