Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Process #13

Open
2 tasks
skipjack opened this issue Dec 28, 2017 · 3 comments
Open
2 tasks

Release Process #13

skipjack opened this issue Dec 28, 2017 · 3 comments

Comments

@skipjack
Copy link
Contributor

skipjack commented Dec 28, 2017

I think we need to figure out a good release process for this repo (not sure what the standard is for other webpack-contrib repos). First things first, we should probably create:

  • A prepublish npm script that runs the build so we don't forget to before publishing
  • Maybe a postpublish npm script that removes the /dist directory?

I did add a release script using standard-version however I'm not really sure how to properly push the tagged commits up to the remote. I don't have permissions to directly push to master and only "Rebase & Merge" / "Squash & Merge" are allowed for PRs which both leave the tag orphaned. Oddly enough, I am able to push tags directly to master so what I've been doing is a "Rebase & Merge", then delete the orphaned tag and create the same one on the new master commit.

Any advice much appreciated. Seeing as I'm not going to be the lead maintainer on this repo, maybe it just makes sense to give master privileges to whoever that's going to be and then they can run the release script and push the commit directly to master.

cc @TheLarkInn @d3viant0ne

@joshwiens
Copy link
Member

@skipjack - Release is handled by webpack-defaults for all the loaders / plugins and will shortly be automated via CircleCi workflows.

@joshwiens
Copy link
Member

The access problem on the other hand has been resolved :)

@skipjack
Copy link
Contributor Author

skipjack commented Jan 7, 2018

The access problem on the other hand has been resolved :)

Cool, thanks -- for now I guess @TheLarkInn and I can just cut releases and push directly to master.

Release is handled by webpack-defaults for all the loaders / plugins and will shortly be automated via CircleCi workflows.

Interesting, I'll look into that (and I know I still owe you / webpack-defaults a remark-lint or some form of markdown lint config). I did start a rebuild branch on webpack.js.org which uses remark so it's finally in the works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants