Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with @angularclass/hmr-loader #69

Open
ocombe opened this issue Sep 14, 2016 · 1 comment
Open

Issue with @angularclass/hmr-loader #69

ocombe opened this issue Sep 14, 2016 · 1 comment
Assignees

Comments

@ocombe
Copy link

ocombe commented Sep 14, 2016

Hello,

I use the @angularclass/hmr-loader npm webpack plugin, but it tries to install a lib named @angularclass-loader, looks like it doesn't handle the / well.

From my webpack config:

loaders: [
            // Support for .ts files.
            {
                test: /\.ts$/,
                loaders: ['awesome-typescript', 'angular2-template', '@angularclass/hmr-loader'],
                exclude: [/\.(spec|e2e)\.ts$/]
            }
@ericclemmons
Copy link
Member

Thanks for the example! $20 says my regex didn't account for this scenario.

I'm also updating it to check if @angularclass/hmr-loader is already require.resolve-able, and skip if so.

(This would mean that this plugin is more of a fallback than a first-line defense)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants