Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where do the ce-* imports come from? they aren't defined in any package.json #2439

Closed
NullVoxPopuli opened this issue Sep 29, 2024 · 0 comments

Comments

@NullVoxPopuli
Copy link

NullVoxPopuli commented Sep 29, 2024

Update: found them! they're in libraries/__shared/webcomponents/src as individual files, rather than top-level packages.

I changed the webcomponents package.json here:

  "type": "module",
  "exports": {
    "./*": "./src/*.js"
  },

And then changed my imports to:

import "webcomponents/ce-without-children";
import "webcomponents/ce-with-children";
import "webcomponents/ce-with-properties";
import "webcomponents/ce-with-event";

(i have no idea what the consequences are for this in the other projects)


I'm looking at adding Ember to this project, and noticed that all the other implementations have

import "ce-without-children";
import "ce-with-children";
import "ce-with-properties";
import "ce-with-event";

without declaring any of those packages in the package.json -- this is generally invalid and breaks strict packagers (such as vite).

Where do these come from?
Are they virtual packages from somewhere?

I couldn't find any of them defined anywhere in this repo.
Whichever dependencies they come from, I'll need to add to my package.json so that the dep and module graphs are both valid.

(Note that I have not taken the time to debug the webpack builds for the other projects, which would definitively have given me the answer -- I figure asking here would be good SEO for future implementers as well)

Thanks!


For some additional context, I'm trying to build my project to then pass to the existing karma + webpack infra so that I don't have to figure out how to translate the vite plugins to webpack for the ember project.
I understand this isn't "how things are done" in this repo, but allowing the per-framework implementation to be a bit closer to the framework's general usage would help with long term maintenance and allow "just anyway" to do updates, rather than have to learn (what is for some people) foreign tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant