ghactions.notifyHandler doesn't get called for requests to /api/checks/github-actions #4009
Comments
This was referenced Sep 20, 2024
|
I believe #4010 and web-platform-tests/wpt#48293 will fix this. |
gsnedders
added a commit
to gsnedders/wpt.fyi
that referenced
this issue
Sep 24, 2024
Per the mux docs, "Routes are tested in the order they were added to the router. If two routes match, the first one wins." This means that `checks.RegisterRoutes()` needs to be called after everything else defining a route in /api/checks/ as it otherwise matches every path under /api/checks/.
past
pushed a commit
that referenced
this issue
Sep 25, 2024
Per the mux docs, "Routes are tested in the order they were added to the router. If two routes match, the first one wins." This means that `checks.RegisterRoutes()` needs to be called after everything else defining a route in /api/checks/ as it otherwise matches every path under /api/checks/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See the discussion at web-platform-tests/wpt#48223. This run should have ended up at ghactions.notifyHandler, but instead was handled by checks.updateCheckHandler.
The text was updated successfully, but these errors were encountered: