Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resizable-arraybuffer and growable-sharedarraybuffer should be removed in favor of resizable-buffers #2254

Open
syg opened this issue Nov 15, 2024 · 8 comments
Labels
external Issue or PR caused upstream or downstream

Comments

@syg
Copy link

syg commented Nov 15, 2024

I raised an issue some time ago that the resizable-arraybuffer and growable-sharedarraybuffer features should be combined into a single feature. That has resulted in resizable-buffers, but now we just have all 3. :)

Let's remove resizable-arraybuffer and growable-sharedarraybuffer.

@atopal
Copy link
Collaborator

atopal commented Nov 15, 2024

cc @Elchi3

@Elchi3
Copy link
Collaborator

Elchi3 commented Nov 18, 2024

I removed them in #1605.

Where do they still show up?

@syg
Copy link
Author

syg commented Nov 18, 2024

I removed them in #1605.

Where do they still show up?

On webstatus.dev, both on the main page, https://webstatus.dev/features/resizable-arraybuffer, and https://webstatus.dev/features/growable-sharedarraybuffer

@Elchi3
Copy link
Collaborator

Elchi3 commented Nov 18, 2024

@atopal I guess this is more an issue for https://github.com/GoogleChrome/webstatus.dev

@atopal
Copy link
Collaborator

atopal commented Nov 19, 2024

@jcscottiii I'm assuming this is an issue, because we're not handling merged features yet?

@ddbeck ddbeck added the external Issue or PR caused upstream or downstream label Nov 19, 2024
@jcscottiii
Copy link

@jcscottiii I'm assuming this is an issue, because we're not handling merged features yet?

@atopal Essentially, yes. Also, on webstatus.dev, we do not automatically delete feature IDs if they disappear in the web-features repository. We can do that if that's desired though.

I have marked those two feature IDs to be excluded from now on.

Also, @ddbeck. I think #1605 should have been a breaking change and moved this from v1.x.x to v2.x.x according to this, right?

- Previously valid references are invalid (for example, a group ID is renamed or a feature ID is removed).

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 20, 2024

Also, @ddbeck. I think #1605 should have been a breaking change and moved this from v1.x.x to v2.x.x according to this, right?

@jcscottiii Yes, however we didn't document or start doing semver until after that PR, with v1.3.0.

Since 1.0.0, we've had these removals:

  • canvas-2d-color-managment
  • canvas-text
  • canvas-text-baselines
  • gravity-sensor
  • growable-sharedarraybuffer
  • resizable-arraybuffer

If those still exist on web.dev, I'd suggest pruning them. And if we remove features at later major releases, I'd suggest dropping those too. But hopefully that will be rare (or we'll have some data structure to indicate renames, merges, etc).

@jcscottiii
Copy link

Thanks for that list @ddbeck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issue or PR caused upstream or downstream
Projects
None yet
Development

No branches or pull requests

5 participants