Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The merging logic of the generator options is missing #8965

Open
inottn opened this issue Jan 8, 2025 · 0 comments
Open

[Bug]: The merging logic of the generator options is missing #8965

inottn opened this issue Jan 8, 2025 · 0 comments
Assignees
Labels
bug Something isn't working pending triage The issue/PR is currently untouched.

Comments

@inottn
Copy link
Collaborator

inottn commented Jan 8, 2025

System Info

System:
OS: macOS 14.2
CPU: (8) arm64 Apple M1
Memory: 79.72 MB / 8.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 22.3.0 - ~/.nvm/versions/node/v22.3.0/bin/node
npm: 10.8.1 - ~/.nvm/versions/node/v22.3.0/bin/npm
pnpm: 9.15.0 - ~/.nvm/versions/node/v22.3.0/bin/pnpm
Browsers:
Chrome: 131.0.6778.206
Safari: 17.2

Details

If a module's type is asset/resource, then its generator options should be merged with the generator options for the asset type. This also holds true for types such as css/module. The differences between webpack and rspack outputs can be seen in the linked reproduction repo.

Reproduce link

https://github.com/inottn/merge-global-generator

Reproduce Steps

  1. clone reproduction repo
  2. pnpm install
  3. pnpm run build
@inottn inottn added bug Something isn't working pending triage The issue/PR is currently untouched. labels Jan 8, 2025
@inottn inottn self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending triage The issue/PR is currently untouched.
Projects
None yet
Development

No branches or pull requests

1 participant